Remove eventsystem Inline.cc and cleanup private headers. #12581
Conversation
|
There is one issue with this PR where Continuation.h externs |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the eventsystem Inline.cc file and eliminates private header dependencies by converting inline functions to regular implementations and consolidating code that was previously split across private headers (P_*.h) into public headers or implementation files.
Key changes:
- Removed
Inline.cccompilation unit that previously forced inline function instantiation - Moved inline function implementations from private headers to either public headers (as inline) or implementation files (as regular functions)
- Updated all includes to use public headers instead of private
P_EventSystem.hand related headers - Deleted several private headers that are no longer needed (
P_VConnection.h,P_VIO.h,P_IOBuffer.h, etc.)
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/iocore/eventsystem/Inline.cc |
Deleted - no longer needed for forcing inline function instantiation |
src/iocore/eventsystem/P_EventSystem.h |
Deleted - consolidated into public headers |
src/iocore/eventsystem/VIO.cc |
New file containing VIO method implementations previously in P_VIO.h |
src/iocore/eventsystem/IOBuffer.cc |
Moved inline functions from P_IOBuffer.h to regular implementations |
src/iocore/eventsystem/UnixEventProcessor.cc |
Moved EventProcessor methods from P_UnixEventProcessor.h |
src/iocore/eventsystem/UnixEThread.cc |
Moved EThread scheduling methods from P_UnixEThread.h |
include/iocore/eventsystem/*.h |
Converted selected functions to inline in public headers |
| Various source files | Updated to include public headers instead of private P_*.h files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| VIO * | ||
| vc_do_io_write(VConnection *vc, Continuation *cont, int64_t nbytes, MIOBuffer *buf, int64_t offset) | ||
| { | ||
| IOBufferReader *reader = buf->alloc_reader(); | ||
|
|
||
| if (offset > 0) { | ||
| reader->consume(offset); | ||
| } | ||
|
|
||
| return vc->do_io_write(cont, nbytes, reader, true); | ||
| } |
There was a problem hiding this comment.
This function vc_do_io_write appears to be duplicated from the removed P_VConnection.h. Consider whether this should be moved to a shared location or if it's intentionally file-specific. The same implementation was in the deleted header file, suggesting it might be used elsewhere.
|
|
||
| int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS; | ||
| int thread_max_heartbeat_mseconds = THREAD_MAX_HEARTBEAT_MSECONDS; | ||
| const ink_hrtime DELAY_FOR_RETRY = HRTIME_MSECONDS(10); |
There was a problem hiding this comment.
The constant DELAY_FOR_RETRY is being defined here but was previously in P_UnixEThread.h. If this constant is used in other translation units, this change could cause linker errors due to multiple definitions, or undefined references if those files haven't been updated to include the necessary declaration.
cmcfarlen
force-pushed
the
remove-inline-eventsystem
branch
from
57f903e to
1674d92
Compare
3 participants
No description provided.